Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(js): update generated .swcrc file to align with @swc/core@1.3.85 #19214

Merged
merged 2 commits into from
Sep 22, 2023
Merged

fix(js): update generated .swcrc file to align with @swc/core@1.3.85 #19214

merged 2 commits into from
Sep 22, 2023

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented Sep 18, 2023

This PR fixes an issue with .swcrc using options that are now invalid in @swc/core@1.3.85. When module.type is es6, the strict and noInterop options cannot be set.

The point is to transpile the library with interop between CJS and ESM, and tests show that the resulting output are the same regardless of these options (even in @swc/core@1.3.84). The following is the expected output, and removing the options don't affect it.

'use strict';

Object.defineProperty(exports, '__esModule', { value: true });

function foo() {
    return 'foo';
}

exports.foo = foo;

See: swc-project/swc@7e8d72d

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@jaysoo jaysoo requested a review from a team as a code owner September 18, 2023 14:40
@vercel
Copy link

vercel bot commented Sep 18, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 22, 2023 0:31am

@nx-cloud
Copy link

nx-cloud bot commented Sep 18, 2023 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 6f99473. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 5 targets

Sent with 💌 from NxCloud.

@jaysoo jaysoo force-pushed the fix/swcrc-options branch 2 times, most recently from 32ca8e5 to e62cb20 Compare September 18, 2023 18:31
@jaysoo jaysoo requested a review from a team as a code owner September 18, 2023 18:31
@jaysoo jaysoo closed this Sep 20, 2023
@jaysoo jaysoo reopened this Sep 20, 2023
@jaysoo jaysoo force-pushed the fix/swcrc-options branch 2 times, most recently from 58024ee to bce1700 Compare September 21, 2023 18:05
@jaysoo jaysoo self-assigned this Sep 21, 2023
@FrozenPandaz FrozenPandaz merged commit 903c4fe into nrwl:master Sep 22, 2023
2 checks passed
@jaysoo jaysoo deleted the fix/swcrc-options branch September 22, 2023 12:25
@timonmasberg timonmasberg mentioned this pull request Sep 23, 2023
Merged
@github-actions github-actions bot mentioned this pull request Sep 23, 2023
Open
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@FrozenPandaz FrozenPandaz FrozenPandaz approved these changes

@ndcunningham ndcunningham ndcunningham approved these changes

@mandarini mandarini Awaiting requested review from mandarini mandarini is a code owner automatically assigned from nrwl/nx-js-reviewers

@vsavkin vsavkin Awaiting requested review from vsavkin vsavkin is a code owner

Assignees

@jaysoo jaysoo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jaysoo @ndcunningham @FrozenPandaz